Add libcamera and libcamera-apps to recipes-multimedia by maurosanjo · Pull Request #963 · agherzan/meta-raspberrypi

maurosanjo · 2021-11-29T18:55:17Z

Enables use of new approach to handle cameras in Raspberry pi boards.

Adds recipe for newest libcamera from https://libcamera.org
Adds recipe for newest libcamera-app from https://github.com/raspberrypi/libcamera-apps

- Add libcamera from latest commit - Add libcamera-apps from latest commit Signed-off-by: Mauro Anjo <maurosanjo@gmail.com>

- Fix libcamera-apps license and remove comments Signed-off-by: Mauro Anjo <maurosanjo@gmail.com>

kraj · 2021-11-29T19:04:46Z

libcamera is already in meta-multimedia layer, please update those recipes instead. meta-raspberrypi is not right destination for this but if there is anything thats RPI specific we can apply it via bbappends.

maurosanjo · 2021-11-29T19:14:07Z

Yes you're right, but current libcamera-apps is incompatible with the older version present in meta-multimedia, that's why i added it here, but can make a PR for meta-multimedia in openembedded, not sure though, since this repo has no tags to state stable versions yet.

libcamera-apps is the new alternative to userland made by raspberry, this might be useful here no?
https://www.raspberrypi.com/documentation/accessories/camera.html#introducing-the-raspberry-pi-cameras

kraj · 2021-11-29T20:13:44Z

Yes you're right, but current libcamera-apps is incompatible with the older version present in meta-multimedia, that's why i added it here, but can make a PR for meta-multimedia in openembedded, not sure though, since this repo has no tags to state stable versions yet.

libcamera-apps is the new alternative to userland made by raspberry, this might be useful here no? https://www.raspberrypi.com/documentation/accessories/camera.html#introducing-the-raspberry-pi-cameras

is libcamera-apps specific to rpi ? or they just need libcamera in that case they are generic

agherzan · 2021-11-29T20:17:00Z

@maurosanjo We had a short chat today about this. Didn't we agree that we should start by uprev-ing meta-multimedia and add apps support as well?

maurosanjo · 2021-11-30T10:40:02Z

@agherzan Yeap, I misunderstood, doing a PR for meta-multimedia.

@kraj the repo states libcamera-apps are apps to mimic raspicam old functionality (userland), but as it uses libcamera it might work with other cameras :)

If you think raspberry/libcamera-apps recipe should be a part of meta-raspberry it should be inside recipes-multimedia ?

kraj · 2021-11-30T15:55:26Z

It’s suitable for meta-multimedia

shr-project · 2021-11-30T17:19:30Z

Just to link these PRs together, this is the libcamera update for meta-oe: openembedded/meta-openembedded#496

and there is another article documenting recent camera changes introduced with Bullseye:
https://www.raspberrypi.com/news/bullseye-camera-system/

this might also eventually replace old raspicam-node in ROS which was available only for 32bit rpi, because of dependency on MMAL from userland (which was available only for 32bit - at least back then, I haven't checked recently):
https://github.com/ros/meta-ros/blob/096229e55080e8a3574ecc071ff2bebb658e20c2/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb

libcamera recipe was made as a PR in openembedded meta-multimedia Signed-off-by: Mauro Anjo <maurosanjo@gmail.com>

maurosanjo · 2021-11-30T20:11:59Z

removed libcamera from this PR. libcamera-apps will be totally focused on raspberry environment and maintained inside Raspberry organization, so I believe it should not be outside of this meta-raspberry scope, what do you guys think?

kraj · 2021-11-30T20:28:00Z

removed libcamera from this PR. libcamera-apps will be totally focused on raspberry environment and maintained inside Raspberry organization, so I believe it should not be outside of this meta-raspberry scope, what do you guys think?

that seems to be ok to have them here I guess.

…ngl in DISTRO_FEATURES and blacklist otherwise * now when we're building for arm with ROS DISTRO and aarch64 with webOS OSE DISTRO it fails to build raspicam-node because default DISTRO configuration doesn't have 'opengl' in DISTRO_FEATURES * fixes: NOTE: Resolving any missing task queue dependencies ERROR: Nothing PROVIDES 'userland' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb DEPENDS on or otherwise requires it) userland was skipped: Recipe is blacklisted: depends on libegl-mesa from mesa-gl which is not available without opengl in DISTRO_FEATURES ERROR: Nothing RPROVIDES 'raspicam-node' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb, /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it) No eligible RPROVIDERs exist for 'raspicam-node' NOTE: Runtime target 'raspicam-node' is unbuildable, removing... Missing or unbuildable dependency chain was: ['raspicam-node'] ERROR: Nothing RPROVIDES 'packagegroup-ros-turtlebot3-core' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb RDEPENDS on or otherwise requires it) No eligible RPROVIDERs exist for 'packagegroup-ros-turtlebot3-core' NOTE: Runtime target 'packagegroup-ros-turtlebot3-core' is unbuildable, removing... Missing or unbuildable dependency chain was: ['packagegroup-ros-turtlebot3-core'] ERROR: Nothing RPROVIDES 'raspicam-node-dev' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it) No eligible RPROVIDERs exist for 'raspicam-node-dev' NOTE: Runtime target 'raspicam-node-dev' is unbuildable, removing... Missing or unbuildable dependency chain was: ['raspicam-node-dev'] * this mess with userland is hopefully temporary and turtlebot3 will eventually use the new implementation introduced in Raspberry Pi OS image based on Debian Bullseye https://www.raspberrypi.com/news/bullseye-camera-system/ there are already some changes for this in meta-raspberrypi: agherzan/meta-raspberrypi#963 and meta-oe: openembedded/meta-openembedded#496 Signed-off-by: Martin Jansa <martin.jansa@lge.com>

agherzan

Can you also please rebase/squash everything into one commit that has the common git log format (https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html#formatting-patches).

agherzan · 2021-12-03T11:44:50Z

recipes-multimedia/libcamera-apps/libcamera-apps.bb

+inherit cmake pkgconfig
+
+# Specify extra options:
+# EXTRA_OECMAKE = "-DENABLE_DRM=0 -DENABLE_X11=0 -DENABLE_QT=0 -DENABLE_OPENCV=1 -DENABLE_TFLITE=0"


Clean up this comment.

Remove it you mean?
Letting user know options to bbapend and customize the build makes sense as a comment?

I'm not sure what this is all about. Could you explain what did you mean by this comment block?

This are cmake options for libcamera-apps, that are documented here:
https://www.raspberrypi.com/documentation/accessories/camera.html#building-libcamera-apps

We can check automatically for this options, if opencv, tensorflow, qt, x11 are present, and -DENABLE_COMPILE_FLAGS_FOR_TARGET=armv8-neon when building for Pi 3 and Pi 4 in 32 bit.

That's what we should do. Based on distro features.

recipes-multimedia/libcamera-apps/libcamera-apps.bb

Add recipe to build raspberry camera apps that uses libcamera and are replacements for userland raspstill and raspvid. Signed-off-by: Mauro Anjo <maurosanjo@gmail.com>

…ta-raspberrypi into add_libcamera_apps

maurosanjo · 2021-12-06T15:35:22Z

Ops, when rebasing and squashing i did something wrong.

Updated the libcamera-apps commit source because newest version of libcamera would crash the build. Also tried to add changes requested by @agherzan , I'm still finding my way around yocto, so please check if this will do.

agherzan

Please also:

rename the recipe to rpi-libcamera-apps_git.bb. This fixes the version in this way and it is clear that the component is from RPI foundation.
squash all commits - the PR should have one and only one commit given what your content is: libcamera-apps: Add recipe for raspberry camera apps

agherzan · 2022-02-23T10:58:53Z

recipes-multimedia/libcamera-apps/libcamera-apps.bb

+S = "${WORKDIR}/git"
+
+DEPENDS = "libcamera opencv boost libjpeg-turbo libexif tiff"
+RDEPENDS:${PN} = "libcamera opencv boost libjpeg-turbo libexif tiff python3-core"


Do we need these RDEPENDS? The packaging should be able to infer them without having them explicit. Any issues with that?

agherzan · 2022-02-23T11:00:51Z

recipes-multimedia/libcamera-apps/libcamera-apps.bb

+
+SRC_URI = "git://github.com/raspberrypi/libcamera-apps.git;branch=main;protocol=https"
+
+PV = "1.0+git${SRCPV}"


There is no such version as far as I can see. I don't see any 1.0 tags in the repo. Just use git in the recipe filename.

agherzan · 2022-02-23T11:07:07Z

recipes-multimedia/libcamera-apps/libcamera-apps.bb

+    ${@bb.utils.contains("MACHINE", "raspberrypi4", "-DENABLE_COMPILE_FLAGS_FOR_TARGET=armv8-neon", "", d)} \
+"
+
+PACKAGECONFIG[qt] = "-DENABLE_QT=1"


Can we have the explicit disable as well for all these PACKAGECONFIG entries?
eg: PACKAGECONFIG[qt] = "-DENABLE_QT=1, -DENABLE_QT=0"

agherzan · 2022-02-23T11:08:42Z

recipes-multimedia/libcamera-apps/libcamera-apps.bb

+
+inherit cmake pkgconfig
+
+EXTRA_OECMAKE = "${@bb.utils.contains("DISTRO_FEATURES", "x11", "-DENABLE_X11=1", "-DENABLE_X11=0", d)} \


This would be nicer to handle as a PACKAGECONFIG. And you enable it by default for the right DISTRO_FEATURES match.

agherzan · 2022-02-23T11:13:32Z

recipes-multimedia/libcamera-apps/libcamera-apps.bb

+
+COMPATIBLE_MACHINE = "^rpi$"
+
+FILES:${PN}-dev = "${includedir} ${libdir}/pkgconfig"


This should be in by default hence not needed.

agherzan · 2022-02-23T11:16:22Z

recipes-multimedia/libcamera-apps/libcamera-apps.bb

+COMPATIBLE_MACHINE = "^rpi$"
+
+FILES:${PN}-dev = "${includedir} ${libdir}/pkgconfig"
+FILES:${PN} += "${libdir}/libpreview.so"


We can remove this and all the following using SOLIBS = ".so". I assume the package provides unversioned libraries only.

maurosanjo · 2022-02-23T11:38:22Z

Hello,

libcamera and libcamera-apps are making a lot of important, and also breaking, changes on last commits. Now the recipe in openembedded for libcamera is no longer compatible with this layer due to meson build options that do not enable raspberry pi libcamera pipelines and ipas.
Take a look here:
openembedded/meta-openembedded@ea6d967

we need to add raspberrypi to -Dpipelines and -Dipas for it to work properly. This should be done inside meta-raspberry pi as a custom recipe for libcamera right?

agherzan · 2022-02-23T11:46:32Z

Hello,

libcamera and libcamera-apps are making a lot of important, and also breaking, changes on last commits. Now the recipe in openembedded for libcamera is no longer compatible with this layer due to meson build options that do not enable raspberry pi libcamera pipelines and ipas. Take a look here: openembedded/meta-openembedded@ea6d967

we need to add raspberrypi to -Dpipelines and -Dipas for it to work properly. This should be done inside meta-raspberry pi as a custom recipe for libcamera right?

Indeed. That sounds like a bbappend here.

agherzan · 2022-07-27T15:36:52Z

Hi @maurosanjo. Any updates on this? I'm tempted to close the MR but it would be a bit of a waste unless you are not onto it anymore.

agherzan · 2022-09-04T17:53:14Z

Hi @maurosanjo. Any updates on this? I'm tempted to close the MR but it would be a bit of a waste unless you are not onto it anymore.

Closing for now but feel free to comment if you manage to pick it up.

maurosanjo added 3 commits November 29, 2021 15:22

Add libcamera and libcamera-apps to recipes-multimedia

bc9d216

- Add libcamera from latest commit - Add libcamera-apps from latest commit Signed-off-by: Mauro Anjo <maurosanjo@gmail.com>

Add libcamera and libcamera-apps

25dfb94

- Fix libcamera-apps license and remove comments Signed-off-by: Mauro Anjo <maurosanjo@gmail.com>

Merge branch 'master' into add_libcamera_apps

788b192

Remove libcamera

53de20b

libcamera recipe was made as a PR in openembedded meta-multimedia Signed-off-by: Mauro Anjo <maurosanjo@gmail.com>

agherzan requested changes Dec 3, 2021

View reviewed changes

maurosanjo added 2 commits December 6, 2021 12:27

libcamera-apps: Add recipe for raspberry camera apps

4ea20c2

Add recipe to build raspberry camera apps that uses libcamera and are replacements for userland raspstill and raspvid. Signed-off-by: Mauro Anjo <maurosanjo@gmail.com>

Merge branch 'add_libcamera_apps' of https://github.com/maurosanjo/me…

2e68295

…ta-raspberrypi into add_libcamera_apps

maurosanjo added 2 commits December 6, 2021 14:03

Merge branch 'agherzan:master' into add_libcamera_apps

f835093

Merge branch 'agherzan:master' into add_libcamera_apps

87898c8

Repository owner deleted a comment from agherzan-ci Feb 21, 2022

agherzan requested changes Feb 23, 2022

View reviewed changes

leigh-johnson added a commit to bitsy-ai/meta-bitsy that referenced this pull request May 29, 2022

libcamera-apps recipe based on agherzan/meta-raspberrypi#963

925adcf

agherzan closed this Sep 4, 2022


		SRC_URI = "git://github.com/raspberrypi/libcamera-apps.git;branch=main;protocol=https"

		PV = "1.0+git${SRCPV}"


		inherit cmake pkgconfig

		EXTRA_OECMAKE = "${@bb.utils.contains("DISTRO_FEATURES", "x11", "-DENABLE_X11=1", "-DENABLE_X11=0", d)} \


		COMPATIBLE_MACHINE = "^rpi$"

		FILES:${PN}-dev = "${includedir} ${libdir}/pkgconfig"

Conversation

maurosanjo commented Nov 29, 2021

Uh oh!

kraj commented Nov 29, 2021

Uh oh!

maurosanjo commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kraj commented Nov 29, 2021

Uh oh!

agherzan commented Nov 29, 2021

Uh oh!

maurosanjo commented Nov 30, 2021

Uh oh!

kraj commented Nov 30, 2021

Uh oh!

shr-project commented Nov 30, 2021

Uh oh!

maurosanjo commented Nov 30, 2021

Uh oh!

kraj commented Nov 30, 2021

Uh oh!

agherzan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maurosanjo commented Dec 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agherzan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maurosanjo commented Feb 23, 2022

Uh oh!

agherzan commented Feb 23, 2022

Uh oh!

agherzan commented Jul 27, 2022

Uh oh!

agherzan commented Sep 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

maurosanjo commented Nov 29, 2021 •

edited

Loading

maurosanjo commented Dec 6, 2021 •

edited

Loading